sebawagner commented on a change in pull request #131:
URL: https://github.com/apache/openmeetings/pull/131#discussion_r581449166
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
##########
@@ -504,9 +504,10 @@ public void onError(Throwable cause) throws Exception {
sipProcessor = Optional.empty();
}
- public void addCandidate(IceCandidate candidate, String uid) {
+ public void addIceCandidate(IceCandidate candidate, String uid) {
if (this.uid.equals(uid)) {
if (!(outgoingMedia instanceof WebRtcEndpoint)) {
+ log.warn("addIceCandidate iceCandidate while
not ready yet, uid: {}", uid);
Review comment:
When enabling this log you can actually find lots of logs about
iceCandidates that are trying to register too early. And we just throw them
away.
We should queue them here and then apply them later.
Otherwise:
- We miss valid iceCandidates and the trickleIce process takes longer then
required (plus performance impact)
- It may not find a valid iceCandidate at all. Which I think leads to the
issue also that the video pods starts and only shows the profile picture
This is also in the documented Kurento Examples (just in the NodeJS ones,
not in the Java examples - the Java ones havn't been updated since 5 years)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
