solomax commented on a change in pull request #131:
URL: https://github.com/apache/openmeetings/pull/131#discussion_r581686464
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
##########
@@ -504,9 +513,11 @@ public void onError(Throwable cause) throws Exception {
sipProcessor = Optional.empty();
}
- public void addCandidate(IceCandidate candidate, String uid) {
+ public void addIceCandidate(IceCandidate candidate, String uid) {
if (this.uid.equals(uid)) {
if (!(outgoingMedia instanceof WebRtcEndpoint)) {
Review comment:
It seems I wasn't clear enough :((
`outgoingMedia` can be
1. `null`
2. `WebRtcEndpoint`
3. `RtpEndpoint`
`!(outgoingMedia instanceof WebRtcEndpoint)` will return `true` in cases `1
and 3`
ice candidated should be queued only in case `1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
