sebawagner commented on a change in pull request #164:
URL: https://github.com/apache/openmeetings/pull/164#discussion_r730471871
##########
File path:
openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/InfoWebService.java
##########
@@ -91,4 +98,38 @@ public Info getVersion() {
public Health getHealth() {
return Health.INSTANCE;
}
+
+ @WebMethod
+ @GET
+ @Path("/manifest.webmanifest")
+ @Produces({"application/manifest+json"})
+ public String getManifest() {
+ JSONObject manifest = new JSONObject();
+ manifest.put("name", OpenmeetingsVariables.getApplicationName()
+ " " + Version.getVersion());
+ manifest.put("short_name",
OpenmeetingsVariables.getApplicationName() + " " + Version.getVersion());
+ manifest.put("description", "Openmeetings provides video
conferencing, instant messaging, white board, collaborative document editing
and other groupware tools.");
+ manifest.put("start_url", "/" +
OpenmeetingsVariables.getApplicationName().toLowerCase(Locale.getDefault()) +
"/?pwa=true");
+ manifest.put("scope", "/");
+ manifest.put("background_color", "#ffffff");
+ manifest.put("theme_color", "#ffffff");
+ manifest.put("dir", "auto");
+ manifest.put("display", "standalone");
+ manifest.put("orientation", "landscape");
+ JSONArray icons = new JSONArray();
+ icons.put(generateIcon("manifest-icon-512.maskable.png",
"512x512", "maskable"));
+ icons.put(generateIcon("manifest-icon-192.maskable.png",
"192x192", "maskable"));
Review comment:
It is not a favicon? Favicon is whats displayed on the browser menu bar.
Nothing to do with a favicon here.
The icons are the icons displayed on the home screen. Favicon is way smaller
then this. Also they have this "Maskable" thing.
Those icons are required since different mobile apps require different image
resolutions. Above 2 icons are apparently the minimum required pre-rendered
icons for Android.
At least according to this source:
https://itnext.io/pwa-splash-screen-and-icon-generator-a74ebb8a130
> Google’s Android platform respects Web App Manifest API specs and it
expects you to provide at least 2 icon sizes in your manifest file —
https://developers.google.com/web/fundamentals/web-app-manifest/#icons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
