sebawagner commented on a change in pull request #164:
URL: https://github.com/apache/openmeetings/pull/164#discussion_r730478798
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html
##########
@@ -23,6 +23,35 @@
<head>
<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"/>
<meta name="viewport" content="height=device-height, initial-scale=1,
width=device-width, initial-scale=1" />
+ <link rel="apple-touch-icon" href="images/icons/apple-icon-180.png">
+ <meta name="apple-mobile-web-app-capable" content="yes">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2048-2732.jpg" media="(device-width: 1024px)
and (device-height: 1366px) and (-webkit-device-pixel-ratio: 2) and
(orientation: portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2732-2048.jpg" media="(device-width: 1024px)
and (device-height: 1366px) and (-webkit-device-pixel-ratio: 2) and
(orientation: landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1668-2388.jpg" media="(device-width: 834px) and
(device-height: 1194px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2388-1668.jpg" media="(device-width: 834px) and
(device-height: 1194px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1536-2048.jpg" media="(device-width: 768px) and
(device-height: 1024px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2048-1536.jpg" media="(device-width: 768px) and
(device-height: 1024px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1668-2224.jpg" media="(device-width: 834px) and
(device-height: 1112px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2224-1668.jpg" media="(device-width: 834px) and
(device-height: 1112px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1620-2160.jpg" media="(device-width: 810px) and
(device-height: 1080px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2160-1620.jpg" media="(device-width: 810px) and
(device-height: 1080px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1284-2778.jpg" media="(device-width: 428px) and
(device-height: 926px) and (-webkit-device-pixel-ratio: 3) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2778-1284.jpg" media="(device-width: 428px) and
(device-height: 926px) and (-webkit-device-pixel-ratio: 3) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1170-2532.jpg" media="(device-width: 390px) and
(device-height: 844px) and (-webkit-device-pixel-ratio: 3) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2532-1170.jpg" media="(device-width: 390px) and
(device-height: 844px) and (-webkit-device-pixel-ratio: 3) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1125-2436.jpg" media="(device-width: 375px) and
(device-height: 812px) and (-webkit-device-pixel-ratio: 3) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2436-1125.jpg" media="(device-width: 375px) and
(device-height: 812px) and (-webkit-device-pixel-ratio: 3) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1242-2688.jpg" media="(device-width: 414px) and
(device-height: 896px) and (-webkit-device-pixel-ratio: 3) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2688-1242.jpg" media="(device-width: 414px) and
(device-height: 896px) and (-webkit-device-pixel-ratio: 3) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-828-1792.jpg" media="(device-width: 414px) and
(device-height: 896px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1792-828.jpg" media="(device-width: 414px) and
(device-height: 896px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1242-2208.jpg" media="(device-width: 414px) and
(device-height: 736px) and (-webkit-device-pixel-ratio: 3) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-2208-1242.jpg" media="(device-width: 414px) and
(device-height: 736px) and (-webkit-device-pixel-ratio: 3) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-750-1334.jpg" media="(device-width: 375px) and
(device-height: 667px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1334-750.jpg" media="(device-width: 375px) and
(device-height: 667px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-640-1136.jpg" media="(device-width: 320px) and
(device-height: 568px) and (-webkit-device-pixel-ratio: 2) and (orientation:
portrait)">
+ <link rel="apple-touch-startup-image"
href="images/icons/apple-splash-1136-640.jpg" media="(device-width: 320px) and
(device-height: 568px) and (-webkit-device-pixel-ratio: 2) and (orientation:
landscape)">
Review comment:
> why do we need all those icons?
I've answered that comment in the mailing list:
=>They are generated from the same icon, see:
https://github.com/onderceylan/pwa-asset-generator
But I doubt anybody needs to do that again. Unless OpenMeetings changes its
icon/logo.
We require those icons because iOS requires different icons pre-rendered in
different screen resolutions. Because iOS is special :)
But also it's common in Mobile development to require images in different
screen resolutions pre-compiled.
> Why are they not in public/ folder?
There is an "images" folder and there is a "public" folder. Both folders
contain "images" and both folders are "public" :)
I simply saw images first and it did contain more content, so I placed it
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
