We decided that if you say "on or before 2011-07-25 00:00:00.000" then we should really have our evaluators treat that as "on or before 2011-07-25 + 1d - 1ms". The DAO layer will continue to treat it as as a literal timestamp.
Christian fixed this problem specifically for EncounterCohortQuery: https://tickets.openmrs.org/browse/REPORT-161 There's a ticket for fixing this everywhere else: https://tickets.openmrs.org/browse/REPORT-166 Bailly, if you can create a patch applying the same approach that was taken in REPORT-161 to the ObsCohortQuery classes (or whichever one you're using) that would be great. -Darius On Thu, Aug 11, 2011 at 9:22 AM, Dave Thomas <[email protected]> wrote: > Hi. I think this is actually correct behavior, at least in OpenMRS > technical terms (maybe not great useability though, as bailly points > out). > > When you enter a date, you're really entering an instantaneous point > in time: for example 25/07/2011 means '2011-07-25 00:00:000'. To fix > this the reporting framework would have to universally add a day to > every end date... > > d > > On 8/11/11, Michael Seaton <[email protected]> wrote: > > Hi Bailly, > > > > What Cohort Query are you using and what properties are you setting? > > This has been addressed recently in many of the Cohort Queries - it is > > possible that we didn't get all of them though... > > > > If you could write a unit test demonstrating the failure, that would be > > very welcome :) > > > > Thanks! > > Mike > > > > > > On 08/11/2011 07:10 AM, Bailly Rurangirwa wrote: > >> Hi, > >> it seems the endDate we pass in as a parameter is not taken into account > >> when generating values for the reports ! > >> > >> If for example I want to get the number of patients who requested a > >> primary > >> care service from 20/07/2011 to 25/07/2011 , > >> those who requested the service on 25/07/2011 will not be included. To > >> include them, I would have to increment endDate and use a greater value > >> like > >> 26/07/2011. > >> And this is also true for simple cohort queries that require an endDate > >> parameter. > >> > >> > >> -- > >> View this message in context: > >> > http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Reporting-module-end-date-is-not-included-when-calculating-values-for-reports-tp6675961p6675961.html > >> Sent from the Developers mailing list archive at Nabble.com. > >> > >> _________________________________________ > >> > >> To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > >> [email protected] with "SIGNOFF openmrs-devel-l" in the body > >> (not the subject) of your e-mail. > >> > >> [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] > > > > _________________________________________ > > > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > > [email protected] with "SIGNOFF openmrs-devel-l" in the body > (not > > the subject) of your e-mail. > > > > [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] > > > > _________________________________________ > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > [email protected] with "SIGNOFF openmrs-devel-l" in the body > (not the subject) of your e-mail. > > [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
