It's actually been my experience that our code review process is often
so focused on the actual code, it doesn't always focus as much on
whether the developed product (UI features, etc) works right or meets
all of the initial specifications. Separating the process into code
review (typically "the code looks good, the design is good, you have
unit tests, you follow the right patterns", etc) and functional
testing/approval might explicitly ensure that these steps are always
being followed better.
On 02/03/2012 02:51 PM, Darius Jazayeri wrote:
Mark's point is that sometimes there's a separate QA/QC team (in the
case of this sprint, it's an awesome PIH volunteer named Cordt).
That's an extra, higher level of testing than what happens during our
regular ticket workflow.
And since we don't have a QA/QC team for OpenMRS generally, we
obviously haven't modeled the "to-be-tested-by-QA-QC.
Another option would be to approve the ticket and add a label for
"needs-QA". Once that QA has happened, then remove the label and
possibly reopen the ticket, or create a new ticket.
-Darius
On Fri, Feb 3, 2012 at 11:29 AM, Michael Downey <[email protected]
<mailto:[email protected]>> wrote:
Shouldn't a post-commit code review also be ensuring the code change
actually fixed the problem?
Michael
_________________________________________
To unsubscribe from OpenMRS Developers' mailing list, send an
e-mail to [email protected]
<mailto:[email protected]> with "SIGNOFF
openmrs-devel-l" in the body (not the subject) of your e-mail.
[mailto:[email protected]
<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l]
------------------------------------------------------------------------
Click here to unsubscribe
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list
_________________________________________
To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to
[email protected] with "SIGNOFF openmrs-devel-l" in the body (not
the subject) of your e-mail.
[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
