OK, thanks Carlos, I think I will commit the change, seems like it wouldn't hurt. Anybody else?
On Mon, May 19, 2014 at 5:07 PM, Carlos Scheidecker <[email protected]>wrote: > I am having the same issue Mark. > > The class is not public so it has no visibility > inside opennlp.addons.modelbuilder.impls.GenericModelableImpl therefore it > cannot be built with Maven or resolved inside Eclipse. > > I have also been looking at new commits to fix that and there were none. > > > On Mon, May 12, 2014 at 1:03 PM, Mark G <[email protected]> wrote: > > > Does MarkableFileInputStreamFactory need to be package private? I am > using > > it in an addon (modelbuilder-addon), I would like to either move it or > make > > it a public class. Perhaps I should be using a different class > altogether? > > > > I am using it like this > > > > ObjectStream<String> lineStream = > > new PlainTextByLineStream(new > > MarkableFileInputStreamFactory(params.getAnnotatedTrainingDataFile()), > > charset); > > ObjectStream<NameSample> sampleStream = new > > NameSampleDataStream(lineStream); > > > > where getAnnotatedTrainingDataFile returns a java File object. > > > > thanks > > >
