Jorn, I think it has to be fixed because the add-ons package does not compile without it.
So, regardless the type of fix, as long as the add-ons package compiles and works then I would say I am OK with anything. Cheers On Tue, May 20, 2014 at 2:11 AM, Jörn Kottmann <[email protected]> wrote: > On 05/19/2014 11:24 PM, Mark G wrote: > >> OK, thanks Carlos, I think I will commit the change, seems like it >> wouldn't >> hurt. Anybody else? >> > > We can't do it like that, the cmdline package is marked as internal usage > only. Therefore the classes in there should not be > used outside of it. Inside cmdline pacakge the code is calling this > factory method: > CmdLineUtil.createInputStreamFactory > > Anyway, since user will need to create InputStreamFactory instances here > and there it might be a good > idea to move this class to the util package, or introduce an > InputStreamFactoryUtil class which offers a couple > of factory methods for various inputs (e.g. File, URL, Classpath, etc.). > > Any thoughts? > > Jörn > >
