Rodrigo, thanks for this fix, let me know if you want me to test, or just
put a second set of eyes on any particular parts.
MG

On Wed, Oct 8, 2014 at 2:32 PM, Jörn Kottmann <[email protected]> wrote:

> Well done, this was a serious regression.
>
> You observed this earlier:
> > Only one issue remains: The requirement to add -factory parameter for
> > the -featuregen parameter to work and its backing-off to default
> > features without warning if the -factory param is not used.
>
> Is that still the case with the fix you applied?
>
> We need to add a test case to be able to detect bugs in the setup of the
> feature generation. I wouldn't be surprised if something similar happens
> again at some point.
>
> Jörn
>
> On Wed, 2014-10-08 at 17:27 +0100, Rodrigo Agerri wrote:
> > Hello,
> >
> > On Wed, Oct 8, 2014 at 8:17 AM, Jörn Kottmann <[email protected]>
> wrote:
> > >
> > > +1 for the first option.
> >
> > Great, I have commit and close the issue.
> >
> > Thanks!
> >
> > Rodrigo
>
>
>

Reply via email to