Hello, On Wed, Oct 8, 2014 at 7:32 PM, Jörn Kottmann <[email protected]> wrote: > You observed this earlier: >> Only one issue remains: The requirement to add -factory parameter for >> the -featuregen parameter to work and its backing-off to default >> features without warning if the -factory param is not used. > > Is that still the case with the fix you applied?
Yes, that is still the case. I have open an issue about this too. https://issues.apache.org/jira/browse/OPENNLP-718 Any comments anyone? > We need to add a test case to be able to detect bugs in the setup of the > feature generation. I wouldn't be surprised if something similar happens > again at some point. Yes, perhaps adding a test for features that are not the default ones, or even by type of features: 1. A test for local features different to the default one. 2. A test for features requiring external resources. That way, the descriptors parsing, resources loading and factory creation will all be affected. @markg, this also addresses your comments. What do you think? Cheers, Rodrigo
