On Thu, 2016-10-27 at 16:04 +0000, Russ, Daniel (NIH/CIT) [E] wrote: > Hello, > > Okay, I found why my toy worked. I call > AbstractEventTrainer.doTrain(DataIndexer) as oppose to > AbstractEventTrainer.train(ObjectStream<Event>). The train method > calls isValid(). That sets the value of threads in QNTrainer. > > Thank you for making me do this. I don’t think doTrain() should > be exposed anymore. A new method train(DataIndexer) that calls > isValid and then doTrain(indexer) is probably a better idea. Is it > important to calculate the hash of all events?
This should really be in the init method and not in isValid. What do you think? The init method was added for the plugable ml support in 1.6.0 and I believe I didn't see that this should be moved there. Jörn
