On Fri, 2016-11-04 at 12:58 +0000, Russ, Daniel (NIH/CIT) [E] wrote: > Hi Jörn, > Currently, GIS is a wrapper for the GISTrainer, which ironically > is NOT an EventTrainer. There are several ways to handle this. > > First, don’t touch GIS. This is the class that people know best. It > is easy to use if you use the parameter hard coded in the class. We > can make GISTrainer an Event trainer and refactor it appropriately to > handle parameters in the map. > > Second, refactor GIS, but keep the static methods in the code. This > allows user to keep their code working. > > Third, refactor GIS and deprecate the static methods. > > I don’t see any value to the GIS class other than an Adapter. My > vote would be the fix the original problem of GISTrainer NOT being an > event trainer.
I think we are lucky that GISTrainer is not a public class, so that allows us to modify it as we need. I agree with you, we should make it an EventTrainer. The GIS class should probably just be deprecated and then removed later. Regards, Jörn
