+1 for the OPENNLP-xxx: commit message.


On Tue, Jan 10, 2017 at 12:51 AM, William Colen <[email protected]>
wrote:

> +1 for the OPENNLP-xxx: commit message.
> Fast to find a commit.
>
>
> 2017-01-09 21:24 GMT-02:00 Joern Kottmann <[email protected]>:
>
> > On Mon, 2017-01-09 at 17:02 -0500, Jeffrey Zemerick wrote:
> > > I'm personally a fan of the issue number being the first thing on the
> > > subject line, like "OPENNLP-xxx: commit message." For me it gives a
> > > consistent place to look for the issue without having to read the
> > > full
> > > message. (That way you can also see the issue number in GitHub's
> > > commit
> > > list without having to expand the commit.)
> >
> >
> > Yes, it is also faster to write like that, on the other hand if the
> > subject line is then too short to write something meaningful it is
> > probably better to write it in the body instead.
> >
> > +1 to write it first thing in the subject line in all cases where it is
> > possible, for very rare cases where it doesn't work it can still be in
> > the body
> >
> > Jörn
> >
>

Reply via email to