Should we have a shared hook script that can be used for commit message validation?
Are there other things we would like to do with that? Currently we can easily catch bad commit messages during review, commits usually get squashed into one to not have all the feedback commits in our history. Jörn On Wed, 2017-01-11 at 02:14 +0530, ARUN Thundyill Saseendran wrote: > +1 > > Just to confirm, > > *OPENNLP-xxx[,OPENNLP-yyy,...] : Commit Message* > > Also will there be a pre-commit trigger in git to validate this. > > Thanks > Arun > > On Wed, Jan 11, 2017 at 2:08 AM, Tommaso Teofili <tommaso.teofili@gma > il.com> > wrote: > > > +1 > > > > Tommaso > > > > Il giorno mar 10 gen 2017 alle ore 11:20 Rodrigo Agerri < > > [email protected]> > > ha scritto: > > > > > +1 for the OPENNLP-xxx: commit message. > > > > > > > > > > > > On Tue, Jan 10, 2017 at 12:51 AM, William Colen <william.colen@gm > > > ail.com > > > > > > wrote: > > > > > > > +1 for the OPENNLP-xxx: commit message. > > > > Fast to find a commit. > > > > > > > > > > > > 2017-01-09 21:24 GMT-02:00 Joern Kottmann <[email protected]>: > > > > > > > > > On Mon, 2017-01-09 at 17:02 -0500 <02%200500>, Jeffrey > > > > > Zemerick > > > > wrote: > > > > > > I'm personally a fan of the issue number being the first > > > > > > thing on > > > > the > > > > > > subject line, like "OPENNLP-xxx: commit message." For me it > > > > > > gives a > > > > > > consistent place to look for the issue without having to > > > > > > read the > > > > > > full > > > > > > message. (That way you can also see the issue number in > > > > > > GitHub's > > > > > > commit > > > > > > list without having to expand the commit.) > > > > > > > > > > > > > > > Yes, it is also faster to write like that, on the other hand > > > > > if the > > > > > subject line is then too short to write something meaningful > > > > > it is > > > > > probably better to write it in the body instead. > > > > > > > > > > +1 to write it first thing in the subject line in all cases > > > > > where it > > > > is > > > > > possible, for very rare cases where it doesn't work it can > > > > > still be > > > > in > > > > > the body > > > > > > > > > > Jörn > > > > > > > > > --
