mawiesne commented on code in PR #446:
URL: https://github.com/apache/opennlp/pull/446#discussion_r1038989984
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerFactory.java:
##########
@@ -363,11 +382,11 @@ public void validateArtifactMap() throws
InvalidFormatException {
if (ngramDictEntry != null && !(ngramDictEntry instanceof Dictionary)) {
throw new InvalidFormatException("NGram dictionary has wrong type!");
}
-
}
+ // reduced visibility to ensure deprecation is respected in future versions
@Deprecated
Review Comment:
I've been thinking around at this line for a while. There are so many places
that are deprecated _and_ unused. Worth documenting things that are both? Or
remove or change the visibility so future releases mildly switch users to
change their code to drop deprecated stuff that has been in this state for many
years.
Agreed that we need a policy on how to clean up or handle (internally
unused!) Deprecated things.
Same applies for all other spots I felt an adjustment makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
