kinow commented on code in PR #446:
URL: https://github.com/apache/opennlp/pull/446#discussion_r1038993301
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerFactory.java:
##########
@@ -363,11 +382,11 @@ public void validateArtifactMap() throws
InvalidFormatException {
if (ngramDictEntry != null && !(ngramDictEntry instanceof Dictionary)) {
throw new InvalidFormatException("NGram dictionary has wrong type!");
}
-
}
+ // reduced visibility to ensure deprecation is respected in future versions
@Deprecated
Review Comment:
Yeah, I know Commons really tries to be as backward compatible as possible,
even avoiding updating the minimum JVM version. Jena also cares about breaking
certain parts of the public API that are known/expected to be used in other
systems.
I don't know about OpenNLP though. +1 to having it well documented so
devs/committers are aware of what can be done or not. Thanks for understanding
it @mawiesne !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
