mawiesne commented on code in PR #469:
URL: https://github.com/apache/opennlp/pull/469#discussion_r1057159641
##########
opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractDataIndexer.java:
##########
@@ -188,17 +233,15 @@ protected List<ComparableEvent> index(ObjectStream<Event>
events,
return eventsToCompare;
}
- public int getNumEvents() {
- return numEvents;
- }
-
/**
- * Updates the set of predicated and counter with the specified event
contexts and cutoff.
+ * Updates the set of predicates and counter with the specified event
contexts and cutoff.
+ *
* @param ec The contexts/features which occur in a event.
* @param predicateSet The set of predicates which will be used for model
building.
* @param counter The predicate counters.
* @param cutoff The cutoff which determines whether a predicate is included.
- * @deprecated will be removed after 1.8.1 release
+ *
+ * @deprecated Use {{@link #update(String[], Map)}}. This method will be
removed after 1.8.1 release
Review Comment:
@rzo1 It seems worth documenting the removal on its own, for clarity in
release notes. I'll open a separate Jira for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]