mawiesne commented on code in PR #469:
URL: https://github.com/apache/opennlp/pull/469#discussion_r1057168805
##########
opennlp-tools/src/main/java/opennlp/tools/commons/Trainer.java:
##########
@@ -17,8 +17,36 @@
package opennlp.tools.commons;
+import java.util.Map;
+
+import opennlp.tools.ml.AbstractTrainer;
+import opennlp.tools.ml.EventModelSequenceTrainer;
+import opennlp.tools.util.TrainingParameters;
+
/**
* Represents a common base for training implementations.
*/
public interface Trainer {
+
+ /**
+ * Initializes a {@link AbstractTrainer} via {@link TrainingParameters} and
+ * a {@link Map report map}.
+ *
+ * @param trainParams The {@link Map} that maps training parameters on a
key-value basis.
+ * @param reportMap The {@link Map} instance used as report map.
+ *
+ * @deprecated Use {@link #init(TrainingParameters, Map)} instead.
+ */
+ @Deprecated
+ void init(Map<String, Object> trainParams, Map<String, String> reportMap);
Review Comment:
Resolved with latest commit. The oldskool method now resides in
`AbstractTrainer` not in the `Trainer` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]