mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083408816
##########
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##########
@@ -20,11 +20,18 @@
import opennlp.tools.similarity.apps.HitBase;
-import junit.framework.TestCase;
+import org.junit.Ignore;
+import org.junit.Test;
-public class MultiSentenceSearchResultsProcessorTest extends TestCase {
- MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+import static org.junit.Assert.assertTrue;
+public class MultiSentenceSearchResultsProcessorTest {
+
+ private final MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+
+ @Test
+ @Ignore
+ // This test case fails with: "UnknownHostException:
api.datamarket.azure.com: nodename nor servname provided, or not known"
Review Comment:
@kinow Given
https://www.developer.com/news/microsoft-to-shut-down-azure-datamarket/ , it
seems time to drop those tests and related code.
Nobody will ever benefit having this non-functional "garbage" laying around
in the sandbox.
If you agree, I'd kick those parts out?
##########
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##########
@@ -20,11 +20,18 @@
import opennlp.tools.similarity.apps.HitBase;
-import junit.framework.TestCase;
+import org.junit.Ignore;
+import org.junit.Test;
-public class MultiSentenceSearchResultsProcessorTest extends TestCase {
- MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+import static org.junit.Assert.assertTrue;
+public class MultiSentenceSearchResultsProcessorTest {
+
+ private final MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+
+ @Test
+ @Ignore
+ // This test case fails with: "UnknownHostException:
api.datamarket.azure.com: nodename nor servname provided, or not known"
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
