kinow commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083414241


##########
opennlp-similarity/src/test/java/opennlp/tools/similarity/apps/taxo_builder/TaxonomyBuildMatchTest.java:
##########
@@ -16,36 +16,38 @@
  */
 package opennlp.tools.similarity.apps.taxo_builder;
 
-import java.util.List;
+import org.junit.Test;
 
-import junit.framework.TestCase;
+import static org.junit.Assert.assertTrue;
 
-public class TaxonomyBuildMatchTest extends TestCase {
+public class TaxonomyBuildMatchTest {
 
+  @Test
   public void testTaxonomySeedImport() {
     AriAdapter ad = new AriAdapter();
     ad.getChainsFromARIfile("src/test/resources/taxonomies/irs_dom.ari");
-    System.out.println(ad.lemma_AssocWords);
     assertTrue(ad.lemma_AssocWords.size() > 0);
   }
-/*
-  public void testTaxonomyBuild() {
-    TaxonomyExtenderViaMebMining self = new TaxonomyExtenderViaMebMining();
-    self.extendTaxonomy("src/test/resources/taxonomies/irs_dom.ari", "tax",
-        "en");
-    self.close();
-    assertTrue(self.getAssocWords_ExtendedAssocWords().size() > 0);
-  }
-*/
+
+  /*
+    public void testTaxonomyBuild() {
+      TaxonomyExtenderViaMebMining self = new TaxonomyExtenderViaMebMining();
+      self.extendTaxonomy("src/test/resources/taxonomies/irs_dom.ari", "tax",
+          "en");
+      self.close();
+      assertTrue(self.getAssocWords_ExtendedAssocWords().size() > 0);
+    }
+  */

Review Comment:
   I think there are other commented out code that could be similar to this one 
(haven't check everything, sorry).



##########
opennlp-similarity/src/test/java/opennlp/tools/similarity/apps/taxo_builder/TaxonomyBuildMatchTest.java:
##########
@@ -16,36 +16,38 @@
  */
 package opennlp.tools.similarity.apps.taxo_builder;
 
-import java.util.List;
+import org.junit.Test;
 
-import junit.framework.TestCase;
+import static org.junit.Assert.assertTrue;
 
-public class TaxonomyBuildMatchTest extends TestCase {
+public class TaxonomyBuildMatchTest {
 
+  @Test
   public void testTaxonomySeedImport() {
     AriAdapter ad = new AriAdapter();
     ad.getChainsFromARIfile("src/test/resources/taxonomies/irs_dom.ari");
-    System.out.println(ad.lemma_AssocWords);
     assertTrue(ad.lemma_AssocWords.size() > 0);
   }
-/*
-  public void testTaxonomyBuild() {
-    TaxonomyExtenderViaMebMining self = new TaxonomyExtenderViaMebMining();
-    self.extendTaxonomy("src/test/resources/taxonomies/irs_dom.ari", "tax",
-        "en");
-    self.close();
-    assertTrue(self.getAssocWords_ExtendedAssocWords().size() > 0);
-  }
-*/
+
+  /*
+    public void testTaxonomyBuild() {
+      TaxonomyExtenderViaMebMining self = new TaxonomyExtenderViaMebMining();
+      self.extendTaxonomy("src/test/resources/taxonomies/irs_dom.ari", "tax",
+          "en");
+      self.close();
+      assertTrue(self.getAssocWords_ExtendedAssocWords().size() > 0);
+    }
+  */

Review Comment:
   I think there are other commented out code that could be similar to this one 
(haven't check everything, sorry). Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to