NishantShri4 commented on code in PR #758:
URL: https://github.com/apache/opennlp/pull/758#discussion_r2041237795
##########
opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java:
##########
@@ -257,15 +260,17 @@ public AbstractModel trainModel(int iterations,
DataIndexer di, int cutoff, bool
logger.info("Computing model parameters...");
- MutableContext[] finalParameters = findParameters(iterations, useAverage);
+
+ //@TODO : Ideally an instance of TrainingProgressMonitor will be
introduced via Trainer Factory.
+ MutableContext[] finalParameters = findParameters(iterations, useAverage,
new ConsoleTrainingProgressMonitor());
Review Comment:
Thanks. Added a TrainingConfiguration Record object to initialize the
trainer via TrainerFactory. The trainingConfiguration object embeds the TPM and
StopCriteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
