NishantShri4 commented on PR #758: URL: https://github.com/apache/opennlp/pull/758#issuecomment-2800174286
hi @rzo1, @mawiesne, Hope you are well. I have tried to fix the review comments. Would you pls. be able to review once more and direct towards the intended solution? Many thanks in advance. **Some queries and ToDos:** 1) The jira description gives following prototype of finishedTraining() method. ``` finishedTraining(int iterations, int numberCorrectEvents, int totalEvents, StopCriteria stopCriteria); } ``` Please can you clarify, what is the use of numberCorrectEvents and totalEvents parameters? In my current implementation, I have not used them, instead I found stopCriteria is sufficient. Pls. take a look. 2) ToDo - The TPM & StopCriteria are currently only integrated with Perceptron and GIS Trainer. Integrate with other trainers also. 3) ToDo (if preferred) - The displayAndClear method could use a boolean parameter to control clearing of underlying data structure holding training progress. 4) ToDo : Update the documentation to include description of TPM and StopCriteria. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
