rzo1 commented on PR #1108: URL: https://github.com/apache/opennlp/pull/1108#issuecomment-4799033961
- `Confusables.parse` throws `IllegalStateException` for malformed data while the sibling `CodePointSet.parse` throws `IllegalArgumentException` for the analogous case. Worth aligning or documenting the rationale at the throw sites. - The double-checked retry-after-failure path in `Confusables` (a failed load leaves the field null so a later call retries) isn't exercised by a test. - `opennlp-api/pom.xml` is missing a trailing newline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
