krickert commented on PR #1108: URL: https://github.com/apache/opennlp/pull/1108#issuecomment-4817498232
@rzo1 Thanks for the review — all five addressed (tip `b2a17a1`), all doc/naming, no behavior change. - **`AccentFold` "Creates a folder."** → "Creates an accent-folding normalizer." - **Lucene/BM25 reference in `CaseFold`** → removed; the javadoc now just covers the `Locale.ROOT` lowercasing and the Turkish-i / eszett notes. - **`Confusables` `HashMap(12000)`** → dropped the pre-size (one-time lazy load, so the rehash cost is negligible and the magic number wasn't earning its keep). - **`Confusables` "mirroring CodePointSet.fromFile" comment** → removed; the `IllegalArgumentException` already names the resource + line, so it can't drift from `CodePointSet`. - **`searchDefault()`** → **`defaultChain()`**. Agreed the default isn't search-specific; I also swept the remaining "search" framing out of the normalizer docs and renamed the sibling `NormalizationProfile.searchAnalyzer()` → `matchingAnalyzer()` (#1112) for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
