rzo1 commented on PR #1112: URL: https://github.com/apache/opennlp/pull/1112#issuecomment-4799034516
- `NormalizationProfiles` javadoc states the covered languages are "exactly those with a Snowball stemmer," but `TURKISH` is a valid `SnowballStemmer.ALGORITHM` and has no profile. Either add a Turkish profile or soften the doc to note the deliberate exclusion (the test name `testSupportedLanguagesCoverTheSnowballSet` carries the same overstatement). - `NormalizationProfilesTest` asserts an exact `size == 21`, a magic number that silently bakes in the Turkish gap. Prefer deriving the expected set or asserting intent. - The `MissingResourceException` fallback in `forLanguage` is untested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
