krickert commented on PR #1112:
URL: https://github.com/apache/opennlp/pull/1112#issuecomment-4892048904
@mawiesne Addressed in f99fa629.
- Replaced `Objects.requireNonNull` with `IllegalArgumentException` in the
`NormalizationProfile` compact constructor (`language`, `stemmerAlgorithm`) and
in `NormalizationProfiles.forLanguage`/`detect`; `@throws` javadoc updated.
- Linked the term with `{@link NormalizationProfile profile}` in
`forLanguage` and `detect`.
- Flipped the null-argument tests to `IllegalArgumentException` and added a
`detect(null, ...)` / `detect(..., null)` test.
Rebased onto current main; runtime module green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
