krickert commented on PR #1151: URL: https://github.com/apache/opennlp/pull/1151#issuecomment-4919656298
> I did some _very_ unscientific performance tests on this branch and all changes are positive: > > ``` > ┌─────────────────┬────────────────┬──────────────────────┬─────────┬─────────┐ > │ Corpus │ Old regex (ms) │ New cursor scan (ms) │ New/Old │ Speedup │ > ├─────────────────┼────────────────┼──────────────────────┼─────────┼─────────┤ > │ tweet-like │ 416.52 │ 167.03 │ 0.40× │ 2.49× │ > ├─────────────────┼────────────────┼──────────────────────┼─────────┼─────────┤ > │ plain prose │ 363.45 │ 152.73 │ 0.42× │ 2.38× │ > ├─────────────────┼────────────────┼──────────────────────┼─────────┼─────────┤ > │ url/email heavy │ 232.35 │ 98.55 │ 0.42× │ 2.36× │ > ├─────────────────┼────────────────┼──────────────────────┼─────────┼─────────┤ > │ average │ — │ — │ 0.41× │ ~2.4× │ > └─────────────────┴────────────────┴──────────────────────┴─────────┴─────────┘ > ``` Thank you for doing that. Yeah, I've always hated regex for this. It can be tricky to code, but think the tests cover the big edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
