krickert commented on code in PR #1151:
URL: https://github.com/apache/opennlp/pull/1151#discussion_r3564872304
##########
opennlp-extensions/opennlp-spellcheck/src/main/java/opennlp/spellcheck/normalizer/SpellCheckingCharSequenceNormalizer.java:
##########
@@ -84,21 +84,18 @@ public class SpellCheckingCharSequenceNormalizer implements
CharSequenceNormaliz
/** The default minimum token length below which tokens are left untouched.
*/
public static final int DEFAULT_MIN_TOKEN_LENGTH = 4;
- /** Matches tokens that are entirely digits, optionally with
grouping/decimal marks. */
- private static final Pattern NUMBER_LIKE =
Pattern.compile("[+-]?[\\d.,]*\\d[\\d.,]*%?");
-
- /** Matches URL- and email-like tokens that should never be spell-corrected.
*/
+ /**
+ * Matches URL- and email-like tokens that should never be spell-corrected.
+ * Deliberately still a regex: the three-alternative shape (scheme or www
prefix, mail
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
