krickert commented on PR #1164:
URL: https://github.com/apache/opennlp/pull/1164#issuecomment-4953436888
Thanks. Most of this was in a6f4568a, which landed just before the review
was submitted (the review shows d21612e5 as its head), and the rest is in
b2f017cd. Item by item:
1. Title renamed as suggested.
2. Commentary cut: the class javadocs now state what each class does plus
the two caller contracts (whitespace-delimited emoticon folds, ZWJ and selector
handling). The deprecation note is one sentence plus the replacement link, the
factory note is one javadoc sentence, and the data file header only documents
the row format. The design narrative moved to the PR description under "Design
notes".
3. EmojiEmoticons holds the two direction tables in final fields on an
immutable instance loaded once at class initialization. The volatile field and
the double-checked locking are gone.
4. Javadoc added on every method including the package-private ones; the
match encoding is documented on matchAt's return tag instead of a side comment.
5. Both overrides in both normalizers carry {@inheritDoc} plus the null
contract.
6. normalize and normalizeAligned validate text at the boundary in both
normalizers, and parse rejects a null stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
