krickert commented on code in PR #1150:
URL: https://github.com/apache/opennlp/pull/1150#discussion_r3593793305
##########
opennlp-tools/src/test/java/opennlp/tools/util/StringUtilTest.java:
##########
@@ -37,6 +47,111 @@ void testNoBreakSpace() {
Assertions.assertTrue(StringUtil.isWhitespace((char) 0x202F));
}
+ /**
+ * Pins the exact semantics of {@link StringUtil#isWhitespace(int)} under
the default
+ * {@link WhitespaceMode#UNICODE}, at the code points where the JVM
predicates and the
+ * Unicode {@code White_Space} property disagree, so the predicate cannot
drift silently:
+ * it excludes the {@code U+001C..U+001F} information separators and
includes the next
+ * line control {@code U+0085}, agreeing with {@link
StringUtil#isUnicodeWhitespace(int)}.
+ */
+ @Test
+ void testIsWhitespaceBoundaryCodePointsDefaultIsUnicode() {
+ WhitespaceMode.reset();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
