Re: svn commit: r1482736 - /openoffice/trunk/main/sal/inc/rtl/string.hxx

[Ariel Constenla-Haile]

On Wed, May 15, 2013 at 09:22:51AM -0000, h...@apache.org wrote:
> Author: hdu
> Date: Wed May 15 09:22:51 2013
> New Revision: 1482736
> 
> URL: http://svn.apache.org/r1482736
> Log:
> #i122208# avoid signedness warnings in signed-char build environments
> 
> Modified:
>     openoffice/trunk/main/sal/inc/rtl/string.hxx
> 
> Modified: openoffice/trunk/main/sal/inc/rtl/string.hxx
> URL: 
> http://svn.apache.org/viewvc/openoffice/trunk/main/sal/inc/rtl/string.hxx?rev=1482736&r1=1482735&r2=1482736&view=diff
> ==============================================================================
> --- openoffice/trunk/main/sal/inc/rtl/string.hxx (original)
> +++ openoffice/trunk/main/sal/inc/rtl/string.hxx Wed May 15 09:22:51 2013
> @@ -947,7 +947,7 @@ struct CStringHash
>       size_t operator()( const char* p) const {
>               size_t n = 0;
>               while( *p)
> -                     n += 4*n + *(p++);
> +                     n += 4*n + *static_cast<unsigned char*>(p++);

This breaks on Linux:

Compiling: sal/osl/unx/file.cxx

In file included from ../../inc/rtl/ustring.hxx:33:0,
                 from ../../inc/osl/file.hxx:33,
                 from sal/osl/unx/file.cxx:27:
../../inc/rtl/string.hxx: In member function 'size_t 
rtl::CStringHash::operator()(const char*) const':
../../inc/rtl/string.hxx:950:47: error: invalid static_cast from type 'const 
char*' to type 'unsigned char*'
dmake:  Error code 1, while making '../../unxlngx6/obj/file.obj'
ERROR: error 65280 occurred while making sal/osl/unx



Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

pgppj9BqfODnG.pgp
Description: PGP signature