Andre <[email protected]> has asked for review: Bug 120020: Application crash when undo "Ctrl+Delete" under "Outline" view in SD. https://issues.apache.org/ooo/show_bug.cgi?id=120020
Attachment 80882: Do not delete linked undo actions. https://issues.apache.org/ooo/attachment.cgi?id=80882&action=edit ------- Additional Comments from Andre <[email protected]> The crash is triggered in ~SfxLinkUndoAction() when the pAction member is accessed. This member is destroyed a little earlier by UndoManagerGuard(). The root cause is that undo actions are not reference counted and that ownership is not clearly defined. The attached patch prevents undo actions from being deleted in ~UndoManagerGuard() when they are linked. This would work under the assumption that linked actions would be destroyed by their owners. But that seems to not be the case. Therefore the patch prevents the crash for the cost of leaking undo action objects. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
