On 24/01/2018 Ash Blade wrote:
I have been working on a script to help increase the version of OO in certain files before a release.
Thank you Ash! Noted in https://bz.apache.org/ooo/show_bug.cgi?id=127639
My issue is this: the version is currently set up in the form of x.x.x, but this is for service level I guess. For main release I saw that you sometimes have the form x.x. Is this going to be the rule also in the future or not?
Whatever we publish externally, internally we always keep the x.x.x form (one digit each).
How will the version look like when you will reach 5.0? Will it be in the form 5.0.0 or 5.0?
I guess there is nothing wrong if the script always assumes a 3-digit number, i.e., 4.1.5, or 4.2.0, or 5.0.0. Then, if for some reason we prefer to go with a shorter version like 4.2 or 5.0, then this can be done manually after running the script, since it requires internal agreement among developers. As far as the script is concerned, three digits is the way to go.
Also, how are the rscrevision, build and lastminor variables set in /openoffice/branches/AOO413/main/solenv/inc/minor.mk? Are they done manually by someone or automatically every time you create a new build?
They are done manually, with a simple increase without any special logic behind it (e.g., the previous build was 9876, the next one is 9877). This doesn't play well with branches. So ideally the script here should increase by 1 by default, but also accept an explicit build number as an argument.
Regards, Andrea. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
