On 3/5/2018 8:29 AM, Patricia Shanahan wrote: > > > On 3/4/2018 11:27 PM, Damjan Jovanovic wrote: > ... >> But there is a simple way to both keep the 64->32 bit building working >> while making the 64 bit changes in trunk, and still get the benefits of >> testing. The changes involved to enable the 64 bit build environment >> amount >> to 1 relatively small patch affecting only 5 files, and without this >> patch >> it will still build 32 bit binaries on 64 bit Windows. Thus this patch >> can >> be maintained out-of-tree while patching modules to build on Win64, and >> those building without this patch will end up automatically testing >> whether >> any of the (small and relatively safe) module changes broke the Win32 >> build. > ... > > In general, I favor keeping things checked in, but in keep the patch > that breaks 64->32 in its own branch. The remaining changes can go in > the trunk. > > --- > This email has been checked for viruses by AVG. > http://www.avg.com Speaking with my process engineers hat on this sounds like the best alternative for the time being. It allows the Windows build bots to continue to create binaries that can be used for testing on any Windows system supported by the project as well as maintaining revision control on the 64 bit patch.
Regards Keith
signature.asc
Description: OpenPGP digital signature
