I just committed a fix for this in r1830406. Without this I get build failures due to crashes in the unit tests if --enable-debug is specified. With this change I am able to get a working build with both the system alloc and the internal alloc.
I was unaware that this was not getting used on the gbuild side of things. Why not? It seems like a useful debug feature. On 15 Apr, Damjan Jovanovic wrote: > Alright thank you. > > Would it be better to just scrap cpprt, like gbuild modules already do? > > On Sat, Apr 14, 2018 at 4:59 PM, Don Lewis <truck...@apache.org> wrote: > >> On 14 Apr, Damjan Jovanovic wrote: >> > Hi >> > >> > Can we please upstream the patches from FreeBSD ports, before the 4.2.0 >> > release? >> > >> > That idlc memory alignment SIGBUS crash from >> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206 is Clang >> specific, >> > not FreeBSD specific, and could happen on other operating systems. >> >> That one is a bit complicated to upstream. In the FreeBSD port I only >> apply the patch conditionally when building with recent clang on amd64. >> I could be harmful in terms of memory consumption on 32-bit machines. >> The changes in the patch would need to be #ifdefed in order to import >> it. >> >> Also the changes for the internal allocator are lightly tested at best. >> >> https://svnweb.freebsd.org/ports/head/editors/openoffice- >> devel/files/extra-patch-align16?revision=432895&view=markup >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
