Fixed in 1853558:

Fix a regression in 1853299 caused by a path and pattern match rule
in main/packages that were wrong.

Patch by: me


On Wed, Feb 13, 2019 at 9:04 PM Damjan Jovanovic <dam...@apache.org> wrote:

> Hi
>
> I can reproduce it now. In debug mode (Ctrl+Alt+Shift+D), it gives
> warnings, and when you make it crash, you get the below in the core file.
>
> I'll start a bisect immediately.
>
> #0  ImplCoreDump () at
> /openoffice-git/main/tools/source/debug/debug.cxx:303
> 303        *pTemp = 0xCCCC;
> Current language:  auto; currently c++
> (gdb) bt
> #0  ImplCoreDump () at
> /openoffice-git/main/tools/source/debug/debug.cxx:303
> #1  0x0000000804a934aa in DbgFunc (nAction=<value optimized out>,
> pParam=<value optimized out>) at
> /openoffice-git/main/tools/source/debug/debug.cxx:1295
> #2  0x000000080553ed84 in DbgPrintMsgBox (
>     pLine=0x7fffffff4a30 "Error: ImageAryData::Load: failed to load image
> 'res/commandimagelist/sc_searchdialog.png'\nFrom File
> /openoffice-git/main/vcl/source/gdi/image.cxx at L"...)
>     at /openoffice-git/main/vcl/source/app/dbggui.cxx:1907
> #3  0x0000000804a92874 in DbgOut (pMsg=<value optimized out>,
> nDbgOut=<value optimized out>, pFile=0x805796698
> "/openoffice-git/main/vcl/source/gdi/image.cxx", nLine=<value optimized
> out>)
>     at vector:633
> #4  0x0000000800a3255a in osl_assertFailedLine (pszFileName=0x805796698
> "/openoffice-git/main/vcl/source/gdi/image.cxx", nLine=554,
>     pszMessage=0x80d57d348 "ImageAryData::Load: failed to load image
> 'res/commandimagelist/sc_searchdialog.png'") at diagnose.c:263
> #5  0x000000080560b22e in ImageAryData::Load () at new:236
> #6  0x000000080560c471 in ImageList::GetImage () at new:236
> #7  0x000000080a92ca12 in framework::CmdImageList::getImageFromCommandURL
> (this=0x81c383650, nImageType=0, rCommandURL=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uiconfiguration/imagemanagerimpl.cxx:326
> #8  0x000000080a92cb57 in
> framework::GlobalImageList::getImageFromCommandURL (this=<value optimized
> out>, nImageType=<value optimized out>, rCommandURL=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uiconfiguration/imagemanagerimpl.cxx:367
> #9  0x000000080a92fcf3 in framework::ImageManagerImpl::getImages
> (this=0x81cfc0540, nImageType=<value optimized out>,
> aCommandURLSequence=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uiconfiguration/imagemanagerimpl.cxx:963
> #10 0x000000080a933519 in framework::ModuleImageManager::getImages
> (this=<value optimized out>, nImageType=<value optimized out>,
> aCommandURLSequence=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uiconfiguration/moduleimagemanager.cxx:148
> #11 0x000000080a93353e in non-virtual thunk to
> framework::ModuleImageManager::getImages(short,
> com::sun::star::uno::Sequence<rtl::OUString> const&) (this=<value optimized
> out>, nImageType=4752, aCommandURLSequence=@0x804a934a5)
>     at memory:2050
> #12 0x000000080a989367 in framework::ToolBarManager::RequestImages
> (this=0x81fa3c620) at
> /openoffice-git/main/framework/source/uielement/toolbarmanager.cxx:1563
> #13 0x000000080a9886f1 in framework::ToolBarManager::FillToolbar
> (this=<value optimized out>, rItemContainer=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uielement/toolbarmanager.cxx:1508
> #14 0x000000080a98f93b in framework::ToolBarWrapper::initialize
> (this=0x81fa26800, aArguments=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/uielement/toolbarwrapper.cxx:194
> #15 0x000000080a998931 in framework::MenuBarFactory::CreateUIElement
> (ResourceURL=<value optimized out>, Args=<value optimized out>,
> _pExtraMode=0x80a9b16da "PopupMode", _pAsciiName=0x80a9ab3ab
> "private:resource/toolbar/",
>     _xMenuBar=@0x7fffffff96d0, _xModuleManager=@0x7fffffff9580,
> _xServiceManager=@0x81cfe7b48) at
> /openoffice-git/main/framework/source/uifactory/menubarfactory.cxx:205
> #16 0x000000080a9994e9 in framework::ToolBoxFactory::createUIElement
> (this=<value optimized out>, ResourceURL=@0x81fa26990, Args=@0x7fffffff96d8)
>     at
> /openoffice-git/main/framework/source/uifactory/toolboxfactory.cxx:96
> #17 0x000000080a99957a in non-virtual thunk to
> framework::ToolBoxFactory::createUIElement(rtl::OUString const&,
> com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
> (this=<value optimized out>,
>     ResourceURL=@0x804af1290, Args=@0x804a934a5) at general.h:59
> #18 0x000000080a99d856 in
> framework::UIElementFactoryManager::createUIElement (this=0x81a1a4560,
> ResourceURL=@0x81fa26990, Args=@0x7fffffff96d8)
>     at
> /openoffice-git/main/framework/source/uifactory/uielementfactorymanager.cxx:455
> #19 0x000000080a99d9c2 in non-virtual thunk to
> framework::UIElementFactoryManager::createUIElement(rtl::OUString const&,
> com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
> (this=<value optimized out>,
>     ResourceURL=@0x804af1290, Args=@0x804a934a5) at new:236
> #20 0x000000080a8d4e3c in
> framework::ToolbarLayoutManager::implts_createElement (this=0x8191f1090,
> aName=@0x81fa26990)
>     at
> /openoffice-git/main/framework/source/layoutmanager/toolbarlayoutmanager.cxx:1375
> #21 0x000000080a8d14a8 in
> framework::ToolbarLayoutManager::implts_createToolBar (this=0x8191f1090,
> aName=@0x81fa26990, bNotify=@0x7fffffff98cf, rUIElement=@0x7fffffff98c0)
>     at
> /openoffice-git/main/framework/source/layoutmanager/toolbarlayoutmanager.cxx:1285
> #22 0x000000080a8d12ea in framework::ToolbarLayoutManager::createToolbar
> (this=<value optimized out>, rResourceURL=<value optimized out>)
>     at
> /openoffice-git/main/framework/source/layoutmanager/toolbarlayoutmanager.cxx:458
> #23 0x000000080a8d0963 in framework::ToolbarLayoutManager::requestToolbar
> (this=0x8191f1090, rResourceURL=@0x81fa26990)
>     at
> /openoffice-git/main/framework/source/layoutmanager/toolbarlayoutmanager.cxx:448
> #24 0x000000080a8dcc27 in boost::_bi::bind_t<bool, boost::_mfi::mf1<bool,
> framework::ToolbarLayoutManager, rtl::OUString const&>,
> boost::_bi::list2<boost::_bi::value<framework::ToolbarLayoutManager*>,
> boost::arg<1> > >::operator()<rtl::OUString> (this=0x7fffffff9a20,
> a1=<value optimized out>) at bind_template.hpp:32
> #25 0x000000080a8d0655 in
> framework::ToolbarLayoutManager::implts_createNonContextSensitiveToolBars
> (this=0x8191f1090) at algorithm:965
> #26 0x000000080a8cf758 in
> framework::ToolbarLayoutManager::createStaticToolbars (this=0x8191f1090) at
> /openoffice-git/main/framework/source/layoutmanager/toolbarlayoutmanager.cxx:410
> #27 0x000000080a8c0327 in framework::LayoutManager::implts_reset
> (this=0x800787010, bAttached=1 '\001') at
> /openoffice-git/main/framework/source/layoutmanager/layoutmanager.cxx:407
> #28 0x000000080a8c90a3 in framework::LayoutManager::frameAction
> (this=0x800787010, aEvent=@0x7fffffff9cd0) at
> /openoffice-git/main/framework/source/layoutmanager/layoutmanager.cxx:2858
> #29 0x000000080a90b9bf in framework::Frame::implts_sendFrameActionEvent
> (this=<value optimized out>, aAction=<value optimized out>)
>     at /openoffice-git/main/framework/source/services/frame.cxx:2795
> #30 0x000000080a90dcf7 in framework::Frame::setComponent
> (this=0x80f4b1830, xComponentWindow=@0x7fffffff9e20,
> xController=@0x7fffffff9e18)
>     at /openoffice-git/main/framework/source/services/frame.cxx:1472
> #31 0x000000080a90ebbb in non-virtual thunk to
> framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow>
> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController>
> const&) (
>     this=<value optimized out>, xComponentWindow=@0x0,
> xController=@0x804af1290) at typeinfo:181
> #32 0x00000008034f0691 in SfxFrameLoader_Impl::impl_createDocumentView
> (this=<value optimized out>, i_rModel=@0x7fffffff9ed8,
> i_rFrame=@0x7fffffff9fb0, i_rViewFactoryArgs=<value optimized out>,
> i_rViewName=<value optimized out>)
>     at /openoffice-git/main/sfx2/source/view/frmload.cxx:509
> #33 0x00000008034f0bf9 in SfxFrameLoader_Impl::load (this=<value optimized
> out>, rArgs=<value optimized out>, _rTargetFrame=@0x7fffffff9fb0)
>     at /openoffice-git/main/sfx2/source/view/frmload.cxx:629
> #34 0x000000080a8e18ea in framework::LoadEnv::impl_loadContent
> (this=<value optimized out>) at
> /openoffice-git/main/framework/source/loadenv/loadenv.cxx:1205
> #35 0x000000080a8df9ac in framework::LoadEnv::startLoading
> (this=0x81c37d2c8) at
> /openoffice-git/main/framework/source/loadenv/loadenv.cxx:433
> #36 0x000000080a89d1a7 in framework::LoadDispatcher::impl_dispatch
> (this=<value optimized out>, rURL=@0x81cfb4a58, lArguments=@0x81cfb4ab0,
> xListener=@0x7fffffffa108)
>     at
> /openoffice-git/main/framework/source/dispatch/loaddispatcher.cxx:165
> #37 0x000000080a89d477 in framework::LoadDispatcher::dispatch (this=<value
> optimized out>, aURL=<value optimized out>, lArguments=<value optimized
> out>)
>     at /openoffice-git/main/framework/source/dispatch/loaddispatcher.cxx:92
> #38 0x000000080a900f92 in implDispatchDelayed (pArg=0x81cfb4a50) at
> /openoffice-git/main/framework/source/services/backingwindow.cxx:1019
> #39 0x000000080577abf3 in ImplHandleUserEvent (pSVEvent=0x80d5a8330) at
> MouseEvent.hpp:33
> #40 0x0000000805779336 in ImplWindowFrameProc (pWindow=0x80f4a5590,
> nEvent=22, pEvent=0x80d5a8330) at
> /openoffice-git/main/vcl/source/window/winproc.cxx:2568
> #41 0x000000080dc97713 in SalDisplay::DispatchInternalEvent
> (this=0x80073ba20) at
> /openoffice-git/main/vcl/unx/generic/app/saldisp.cxx:2231
> #42 0x000000080da26619 in GtkXLib::userEventFn (data=0x800763020) at
> /openoffice-git/main/vcl/unx/gtk/app/gtkdata.cxx:817
> #43 0x000000080efbabc7 in g_main_context_dispatch () from
> /usr/local/lib/libglib-2.0.so.0
> #44 0x000000080efbaf53 in g_main_context_pending () from
> /usr/local/lib/libglib-2.0.so.0
> #45 0x000000080efbb004 in g_main_context_iteration () from
> /usr/local/lib/libglib-2.0.so.0
> #46 0x000000080da26774 in GtkXLib::Yield (this=0x800763020, bWait=true,
> bHandleAllCurrentEvents=<value optimized out>) at
> /openoffice-git/main/vcl/unx/gtk/app/gtkdata.cxx:869
> #47 0x000000080554da4d in ImplYield () at decoview.hxx:91
> #48 0x000000080554b01d in Application::Execute () at new:236
> #49 0x0000000800e68ac6 in desktop::Desktop::Main (this=0x7fffffffadd8) at
> app.cxx:2232
> #50 0x0000000805550b87 in ImplSVMain () at
> /openoffice-git/main/vcl/source/app/svmain.cxx:196
> #51 0x0000000805551739 in SVMain () at
> /openoffice-git/main/vcl/source/app/svmain.cxx:237
> #52 0x0000000800eb1b88 in soffice_main () at sofficemain.cxx:45
> #53 0x00000000004011b9 in sal_main () at main.c:31
> #54 0x0000000000401197 in main (argc=1, argv=0x7fffffffaec8) at main.c:30
>
>
>
> On Wed, Feb 13, 2019 at 6:05 PM Matthias Seidel <
> matthias.sei...@hamburg.de> wrote:
>
>> Hi Damjan,
>>
>> Sorry, I only see empty boxes... ;-)
>>
>> But a fresh Windows build from buildbot, revision 1853466 still shows no
>> icons in toolbars:
>>
>> https://www.dropbox.com/s/33hqi8dbvxz8mt0/VirtualBox_Windows%207%20AOO-Build_13_02_2019_16_49_43.png?dl=0
>>
>> I will force a new build for Linux64 now and see how it looks like.
>>
>> Regards,
>>
>>    Matthias
>> Am 13.02.19 um 02:02 schrieb Damjan Jovanovic:
>>
>> Where? I see them:
>> [image: image.png]
>> [image: image.png]
>>
>> On Wed, Feb 13, 2019 at 12:47 AM Matthias Seidel <
>> matthias.sei...@hamburg.de> wrote:
>>
>>> Hi Damjan,
>>>
>>> Am 12.02.19 um 18:01 schrieb Damjan Jovanovic:
>>> > Linux should be fixed in commit 1853456.
>>>
>>> It builds now, but the icons in the toolbars are gone?
>>>
>>> I installed on Linux64 and Windows, both look the same...
>>>
>>> Regards,
>>>
>>>    Matthias
>>>
>>> >
>>> > That commit involved Mac too.
>>> >
>>> > On Tue, Feb 12, 2019 at 5:02 PM Matthias Seidel <
>>> matthias.sei...@hamburg.de>
>>> > wrote:
>>> >
>>> >> Linux64 and Linux32 also break, but in in pyuno:
>>> >>
>>> >>
>>> >>
>>> https://ci.apache.org/projects/openoffice/buildlogs/linux64/main/pyuno/unxlngx6.pro/misc/logs/prj.txt
>>> >>
>>> >>
>>> >>
>>> https://ci.apache.org/projects/openoffice/buildlogs/linux32/main/pyuno/unxlngi6.pro/misc/logs/prj.txt
>>> >>
>>> >> Maybe it is related?
>>> >>
>>> >> Regards,
>>> >>
>>> >>    Matthias
>>> >> Am 11.02.19 um 20:56 schrieb Damjan Jovanovic:
>>> >>
>>> >> On Mon, Feb 11, 2019 at 8:03 PM Jim Jagielski <j...@jagunet.com> <
>>> j...@jagunet.com> wrote:
>>> >>
>>> >>
>>> >> Uggg....
>>> >>
>>> >> looks like breakage from the solenv port to gbuild???
>>> >>
>>> >>
>>> >>
>>> >> Are you sure?
>>> >>
>>> >> I don't see how, it's a very simple port.
>>> >>
>>> >>
>>> >>
>>>
>>>

Reply via email to