Let me know if you want me to kick off another... I have the VMs up and running.
> On Oct 4, 2019, at 4:57 PM, Matthias Seidel <[email protected]> > wrote: > > Thanks, looks (almost) as expected! ;-) > > Am 04.10.19 um 21:51 schrieb Jim Jagielski: >> No prob: >> >> <Screen Shot 2019-10-04 at 3.50.49 PM.png> >> >>> On Oct 4, 2019, at 2:57 PM, Matthias Seidel <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Thanks, could you also expand the "Page" panel? >>> >>> Am 04.10.19 um 20:51 schrieb Jim Jagielski: >>>> <Screen Shot 2019-10-04 at 2.50.34 PM.png> >>>> >>>>> On Oct 3, 2019, at 5:31 PM, Jim Jagielski <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Will do. Likely early next week or maybe even over the weekend. >>>>> >>>>> On 2019/10/03 17:56:59, Matthias Seidel <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>>> Hi Jim, >>>>>> >>>>>> Whenever you have a build of trunk (or 42X) ready on Mac, I would be >>>>>> interested in a screenshot of Writer. >>>>>> I made some visual changes to the sidebar, so all content panels (esp. >>>>>> Page) should be visible. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> Matthias >>>>>> >>>>>> Am 03.10.19 um 18:16 schrieb [email protected] <mailto:[email protected]>: >>>>>>> This is an automated email from the ASF dual-hosted git repository. >>>>>>> >>>>>>> jim pushed a commit to branch trunk >>>>>>> in repository https://gitbox.apache.org/repos/asf/openoffice.git >>>>>>> <https://gitbox.apache.org/repos/asf/openoffice.git> >>>>>>> >>>>>>> >>>>>>> The following commit(s) were added to refs/heads/trunk by this push: >>>>>>> new 8b5576c protect empty vars - fix >>>>>>> https://github.com/apache/openoffice/commit/2d5709ddcf2cff97da30b2b98b71afda0c77781e >>>>>>> >>>>>>> <https://github.com/apache/openoffice/commit/2d5709ddcf2cff97da30b2b98b71afda0c77781e> >>>>>>> 8b5576c is described below >>>>>>> >>>>>>> commit 8b5576ce2f085d55bb1b6ad191acef7e88814942 >>>>>>> Author: Jim Jagielski <[email protected] <mailto:[email protected]>> >>>>>>> AuthorDate: Thu Oct 3 12:15:28 2019 -0400 >>>>>>> >>>>>>> protect empty vars - fix >>>>>>> https://github.com/apache/openoffice/commit/2d5709ddcf2cff97da30b2b98b71afda0c77781e >>>>>>> >>>>>>> <https://github.com/apache/openoffice/commit/2d5709ddcf2cff97da30b2b98b71afda0c77781e> >>>>>>> --- >>>>>>> main/cui/Library_cui.mk | 4 ++-- >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/main/cui/Library_cui.mk b/main/cui/Library_cui.mk >>>>>>> index 927ba50..dbeb4dd 100644 >>>>>>> --- a/main/cui/Library_cui.mk >>>>>>> +++ b/main/cui/Library_cui.mk >>>>>>> @@ -33,8 +33,8 @@ $(eval $(call gb_Library_set_include,cui,\ >>>>>>> -I$(SRCDIR)/cui/source/inc \ >>>>>>> )) >>>>>>> >>>>>>> -ifneq ($(BUILD_VER_STRING),) >>>>>>> -$$(eval $$(call >>>>>>> gb_Library_add_defs,cui,-DBUILD_VER_STRING="$(BUILD_VER_STRING)")) >>>>>>> +ifneq ($(strip $(BUILD_VER_STRING)),) >>>>>>> +$(eval $(call >>>>>>> gb_Library_add_defs,cui,-DBUILD_VER_STRING="$(BUILD_VER_STRING)")) >>>>>>> endif >>>>>>> >>>>>>> $(eval $(call gb_Library_add_defs,cui,\ >>>>>>> >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> <mailto:[email protected]> >>>>> For additional commands, e-mail: [email protected] >>>>> <mailto:[email protected]> >>>>> >>>> >>
