PatriciaShanahan commented on pull request #31:
URL: https://github.com/apache/openoffice/pull/31#issuecomment-660641717
It is difficult to verify experimentally, because the symptom would be
failure to dispose of an object that is no longer needed.
From a code inspection point of view, it looks valid to me. It appears to be
a copy-paste-edit error, in which an edit was missed. The block for disposing
of xListener was probably copied while writing the block for xDocListener, but
one instance of xListener was not changed to xDocListener.
```
else if ( xListener.is() )
m_pData->m_aInterfaceContainer.removeInterface( ::getCppuType((const
uno::Reference< XEVENTLISTENER >*)0), xListener );
else if ( xDocListener.is() )
m_pData->m_aInterfaceContainer.removeInterface( ::getCppuType((const
uno::Reference< XDOCEVENTLISTENER >*)0), xListener );
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
