ardovm commented on pull request #89: URL: https://github.com/apache/openoffice/pull/89#issuecomment-662696345
I started to dig a bit deeper into CFF and Type2, then I understood they are out of my reach. In the end, if the code works well as it is, I would refrain to change it any more than this. Here is what I understood about the other fixed-size arrays: `CffSubsetterContext::mnValStack`, `CffSubsetterContext::mnTransVals` and `CffSubsetterContext::mnHintStack`. They are sized as per the Type 2 Charstring Format specifications, appendix B. They are often accessed by index, i.e. not only by push and pop operations. Are we interested in adding run-time checks on their boundaries? Limits should not be crossed by compliant fonts. If we wanted to minimize the size of objects, we could move them to the heap using fixed-size `std::vector`, but I am not sure we need this. Please note that I partially reverted one commit. I could force-push and merge everything into a single commit to make merging simpler. I am waiting for indications, on whether and how to proceed any further. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
