ardovm commented on pull request #89: URL: https://github.com/apache/openoffice/pull/89#issuecomment-662862458
> Thanks for the feedback. I think the patch is then feature complete. > To have one commit that can be simple be merged would be nice. Please do the merge. Done. > I am not sure if there is some unit test around. I will check on this when I review. But it would be preferable if we could add a unit test that checks the behavior. > > > Are we interested in adding run-time checks on their boundaries? > > can we create a test scenario that may break the boundaries? - If we have a unit test that manages to break the code I say yes we should implement checks for that, that are efficient as possible. If I understand correctly the matter, we should test the code against actual CFF fonts. I would not know where to start. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
