OK... so $shift is a number then, or should be? But sometimes $shift is simply 
blank. And we want a black $shift to be evaluated as 0. So if all that is 
correct, could we use number($shift)>0 ?

I'm thinking this isn't the problem though with the failures :/


> On Oct 21, 2020, at 2:15 PM, Don Lewis <truck...@apache.org> wrote:
> 
> On 21 Oct, Jim Jagielski wrote:
>> Should that fix be just:
>> 
>>    <xsl:if test="string-length($shift)!=0">
> 
> That would work, but it would produce a different output.  It would
> always put ">> $shift" in the output whenever $shift is nonblank.  The
> change that I committed only puts ">> $shift" in the output if $shift is
> nonblank and greater than zero.  This is what the original version does
> with older versions of libxslt, or when building on anything newer than
> CentOS 5.
> 
>> 
>>> On Oct 21, 2020, at 11:37 AM, Jim Jagielski <j...@jagunet.com> wrote:
>>> 
>>> I don't have it, but that was around the end of Aug right? So right around 
>>> the time when a bunch of stuff was included like updates to nss, libxslt, 
>>> libxml2...
>>> 
>>> I'm trying to get my head around the logic of
>>> 
>>>   
>>> https://github.com/apache/openoffice/commit/9510f3847723b65ae47efff8796e6f14f586ce09
>>> 
>>>> On Oct 21, 2020, at 10:58 AM, Matthias Seidel <matthias.sei...@hamburg.de> 
>>>> wrote:
>>>> 
>>>> Hi Jim,
>>>> 
>>>> Am 21.10.20 um 16:54 schrieb Jim Jagielski:
>>>>> Let me double check.. I am rebuilding AOO417. Lets see if that works.
>>>>> 
>>>>> PS: The one change that DID happen is that I upgraded Vmware Fusion, 
>>>>> which I use to run the CentOS5 VMs. That should NOT make any difference. 
>>>>> But we will see.
>>>>> 
>>>>> I'll posted when my 4.1.7 test builds are ready. TIA!
>>>> 
>>>> To be clear, the last version that worked for me was 4.1.8.
>>>> But it was before we built Release Candidates.
>>>> 
>>>> Unfortunately, I didn't keep it, but maybe you can upload it again?
>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>>>>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>>>>> 
>>>> 
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>>> 
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org 
> <mailto:dev-unsubscr...@openoffice.apache.org>
> For additional commands, e-mail: dev-h...@openoffice.apache.org 
> <mailto:dev-h...@openoffice.apache.org>

Reply via email to