ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -106,11 +105,11 @@ public:
};
/**************** SwReader/Reader ************************/
-// Basisklasse der moeglichen Optionen fuer einen speziellen Reader
+// base class for different specialized readers
class Reader;
-// Ruft den Reader mit seinen Optionen, Dokument, Cursor etc.
+// calls a document with its options, document, cursor etc.
Review comment:
should it this call a Reader instead? It makes sense if "Reader" is the
class
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
Review comment:
Could Textbaustein be translated as "text building block"?
I have no idea what it would mean... in both languages, though
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -226,12 +225,12 @@ protected:
SvStream* pStrm;
SotStorageRef pStg;
com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
SwgReaderOption aOpt;
sal_Bool bInsertMode : 1;
sal_Bool bTmplBrowseMode : 1;
- sal_Bool bReadUTF8: 1; // Stream als UTF-8 interpretieren
+ sal_Bool bReadUTF8: 1; // interpred stream as UTF-8
Review comment:
maybe "interpre**te**d"
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
Or "before loading"? I have no idea :-(
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -161,32 +160,32 @@ class SwReader: public SwDocFac
SvStream* pStrm;
SotStorageRef pStg;
com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
SwPaM* pCrsr;
String aFileName;
String sBaseURL;
public:
/*
- * Initiales Einlesen. Dokument wird erst beim Read(..) angelegt.
- * JP 25.04.95: oder falls es mitgegeben wird, in dieses.
- * Sonderfall fuer Load mit Sw3Reader
+ * Initial read. document is created when function Read(...) os called
Review comment:
"os" or "is" ?
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
- // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+ // search next bookmark position from the bookmark table
sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
// build a bookmark table, which is sort by the node position. The
// OtherPos of the bookmarks also inserted.
void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
xub_StrLen nStt, xub_StrLen
nEnd,
SvPtrarr& rArr );
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
static SwPaM * NewSwPaM(SwDoc & rDoc,
sal_uLong const nStartIdx, sal_uLong const
nEndIdx);
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
sal_Bool CopyLocalFileToINet( String& rFileNm );
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
SvStream& OutLong( SvStream& rStrm, long nVal );
SvStream& OutULong( SvStream& rStrm, sal_uLong nVal );
- // Hex-Zahl ausgeben, default ist 2.stellige Zahl
+ // print Hex-Zahl, default is 2. digit number
Review comment:
Hex-Zahl could be translated into "hexadecimal number" unless Hex-Zahl
is an actual class or type name
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -45,7 +45,7 @@
#include <errhdl.hxx>
#include <iodetect.hxx>
-// einige Forward - Deklarationen
+// some forward declerations
Review comment:
decl**a**rations ;-)
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
- sal_uInt16 GetCount() const;
// Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; //
Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const;
// return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; //
return Index of shortnames
sal_uInt16 GetLongIndex( const String& ) const; //Index fuer
Langnamen ermitteln
- const String& GetShortName( sal_uInt16 ) const; // Kurzname
fuer Index zurueck
- const String& GetLongName( sal_uInt16 ) const; // Langname
fuer Index zurueck
+ const String& GetShortName( sal_uInt16 ) const; // return a
shortname of an index
+ const String& GetLongName( sal_uInt16 ) const; // return
longname of an index
- sal_Bool Delete( sal_uInt16 ); // Loeschen
- sal_uInt16 Rename( sal_uInt16, const String*, const String* ); //
Umbenennen
+ sal_Bool Delete( sal_uInt16 ); // delete
+ sal_uInt16 Rename( sal_uInt16, const String*, const String* ); // rename
sal_uLong CopyBlock( SwTextBlocks& rSource, String& rSrcShort,
- const
String& rLong ); // Block kopieren
+ const
String& rLong ); // copy block
- sal_Bool BeginGetDoc( sal_uInt16 ); // Textbaustein
einlesen
- void EndGetDoc(); //
Textbaustein wieder loslassen
+ sal_Bool BeginGetDoc( sal_uInt16 ); // read
AutoText entry
+ void EndGetDoc(); //
release AutoText entry
- sal_Bool BeginPutDoc( const String&, const String& ); // Speichern
Beginn
- sal_uInt16 PutDoc();
// Speichern Ende
+ sal_Bool BeginPutDoc( const String&, const String& ); // start save
+ sal_uInt16 PutDoc();
// End save
- sal_uInt16 PutText( const String&, const String&, const String& ); //
Speichern( Kurzn., Text)
+ sal_uInt16 PutText( const String&, const String&, const String& ); //
save (short., Text)
Review comment:
IMHO "short." here is not clearly identified as "shortname". Maybe it's
worth not abbreviating it.
##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
- // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+ // search next bookmark position from the bookmark table
sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
// build a bookmark table, which is sort by the node position. The
// OtherPos of the bookmarks also inserted.
void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
xub_StrLen nStt, xub_StrLen
nEnd,
SvPtrarr& rArr );
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
static SwPaM * NewSwPaM(SwDoc & rDoc,
sal_uLong const nStartIdx, sal_uLong const
nEndIdx);
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
sal_Bool CopyLocalFileToINet( String& rFileNm );
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
Review comment:
Maybe "optimization"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
