ardovm commented on a change in pull request #126:
URL: https://github.com/apache/openoffice/pull/126#discussion_r614337486
##########
File path: main/cui/source/dialogs/about.cxx
##########
@@ -502,13 +502,14 @@ const rtl::OUString AboutDialog::GetBuildId() const
// For better readability, strip the duplicate ProductMajor ("340").
if ( sProductSource.getLength() )
{
+ sal_Int32 versionLength = sProductSource.getLength() - 3;
Review comment:
Actually, this should be named "productMajorLength" to be consistent
with the above comment. It's probably worth renaming for the sake of clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
