Hi Yuri,
Nice work! However there is more then One change I am unsure about.
# you removed the __cplusplus string check. I think that is a bit hacky.
It would have benn better to check the content and add it with or
# switching to C11 -> we should do this and start refactoring the code
to the C11 style. However again we should check that all our target are
aware of C11, and then have a plan to move up the compiler versions. I
think [1] will help creating such a plan.
This are 2 points where we should think a bit before looking into the
next steps what we would need to do.
Again I really like the way to go. It needs some more work until we can
set this up.
[1] https://en.cppreference.com/w/cpp/compiler_support
On 19.06.21 13:50, Yury Tarasievich wrote:
On 2021/06/18 07:08:17, Yury Tarasievich wrote
...
I've managed to actually finish the build with the changes:
https://gist.github.com/yurytch/9725e3281f9ef784cbf865fcebf51517
(plus some info in two comments)
This is of course a kludge cubed, but at the moment it seems to serve.
I didn't see any crashes yet, although I didn't pressure the app too
much, either.
Stuff with BOOST_NO_CXX11... vars needs to go into global variables
set, of course.
Give it a look guys.
-Yury
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
