leginee opened a new pull request, #155: URL: https://github.com/apache/openoffice/pull/155
I have added the if clause, with the expectation it fullfills the goal czeslav formulated in comment 9 `1. Truncated string It was fixed in version 3.0.0 (cf. the attached file "juxtaVER.jpeg") 2. A spurious colon ralphie, [comment #4](https://bz.apache.org/ooo/show_bug.cgi?id=60217#c4) > Furthermore, if there is no database selected, there is > a spurious colon after this sentence, see: > > http://www.pangea.at/%7eralph/datenbank-austauschen.png If no database is selected, there is a colon after the "sentence". And the program unnecessarily displays a dot character. (cf. the attached file "Period.jpg"). the source file: changedb.cxx http://openoffice-vm1-he-de.apache.org/xref/trunk/main/sw/source/ui/fldui/changedb.cxx?r=efeef26f#333 333 void SwChangeDBDlg::ShowDBName(const SwDBData& rDBData) 334 { 335 String sTmp(rDBData.sDataSource); 336 String sName; 337 sTmp += '.'; 338 sTmp += (String)rDBData.sCommand; 339 340 for (sal_uInt16 i = 0; i < sTmp.Len(); i++) 341 { 342 sName += sTmp.GetChar(i); 343 if (sTmp.GetChar(i) == '~') 344 sName += '~'; 345 } 346 347 aDocDBNameFT.SetText(sName); 348 } Look at the lines 335 - 338 I am not a software developer... but if the properties "sDataSource" and "sCommand" are empty then the programm should set the "sName" variable to empty otherwise proceed as usual.` Did not build the PR. Needs testing, but can be a base of discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
