Hello Damjan, On Sun, May 11, 2025 at 10:03:06AM +0200, Damjan Jovanovic wrote:
> Hi > > To test my recent work on changing OpenOffice to call ICU only through its > C API, I tried to get the i18n unit tests in main/qadevOOo working. > > -------------------------------------------------------- > Porting main/qadevOOo tests to test/ > -------------------------------------------------------- > I debated whether to get them working in their old test framework, or to > port them to our new one in test/, and chose the latter for many reasons. [...] > And I got it working. All 11 of the i18n Java unit test files and 101 test > cases they contain are now in test/testuno/source/api/i18n. They've been > ported from their old test framework to the new JUnit-based one we use in > test/testuno. Great job! > One i18n unit test I ported from main/qadevOoo helped to find a serious bug > in my icu-c-api branch, where a previous call to "delete body" wasn't > changed to "ical_close(body)" like it should have been, resulting in memory > corruption and a crash of OpenOffice. I quickly fixed this once I found it, > but it's a good example of why good unit tests matter. Definitely :-) [...] > There is another related issue I am investigating in > https://bz.apache.org/ooo/show_bug.cgi?id=87590 and the test that > reproduces it has been @Ignored for now. We need to upgrade to a newer > version of Unicode to fix it. I am not sure whether we should update our > case folding tables which are only used in a single place, or delete them > and call the ICU functions for case folding instead. ICU seems the best choice, also according to comment #2 of the bug report, but I understand it is not the quickest. Thank you for your work! -- Arrigo --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
