leginee commented on PR #88: URL: https://github.com/apache/openoffice/pull/88#issuecomment-4757424363
i have the case reviewed. # Why decrease specifically fails On a US/UK keyboard, < is physically Shift+comma, so pressing "Ctrl+<" generates a key event of KEY_LESS + SHIFT + MOD1. But the PR binds decrease to LESS_MOD1 = KEY_LESS + MOD1 (no shift). The event carries SHIFT, the binding doesn't → no match → shrink never fires. Increase works only by luck of the asymmetry: > is Shift+period, generating KEY_GREATER + SHIFT + MOD1, and the PR happens to bind it to GREATER_SHIFT_MOD1 — which does include SHIFT, so it matches. So the same one-character inconsistency I flagged is precisely what users are reporting. The fix is LESS_MOD1 → LESS_SHIFT_MOD1. (This also explains why Pilot-Pirx said setting it by hand worked — he'd have entered a consistent combo.) The separate "jumps by 2" complaint That's not the binding — it's the command implementation. Writer's handler ([txtattr.cxx:247-280](vscode-webview://0and1hd7healr0tlpsb02psleiicthqlvde48hdaraebfrgihgpa/main/sw/source/ui/shells/txtattr.cxx#L247)) uses a hard-coded step: const SwTwips lFontInc = 2 * 20; // +/- 2pt (txtattr.cxx:78) const SwTwips lFontMaxSz = 72 * 20; // cap 72pt, floor 4pt So .uno:Grow/.uno:Shrink change size by a flat ±2pt (4–72pt range), rather than stepping through the standard size list (8,9,10,11,12,14,16,18…) the way MS Word (Ctrl+[ / Ctrl+]) and LibreOffice (Ctrl+8 / Ctrl+9) do. That's long-standing AOO behavior, not something the PR introduced — and it's why Pilot-Pirx says it "does not work as expected." # Net verdict on PR #88 Binding bug (real, fixable): decrease broken by the missing SHIFT → change to LESS_SHIFT_MOD1. Key-choice question (needs dev@): cbmarcum's point stands — Ctrl+[/] (MS) or Ctrl+8/9 (LO) would be more conformant and layout-robust than </>. Behavior complaint (pre-existing, out of PR scope): the ±2pt step lives in the command, not the shortcut. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
