leginee commented on code in PR #485:
URL: https://github.com/apache/openoffice/pull/485#discussion_r3455513242
##########
main/sc/source/ui/view/viewdata.cxx:
##########
@@ -2952,6 +2952,15 @@ void ScViewData::ReadUserDataSequence(const
uno::Sequence <beans::PropertyValue>
pTabData[nZoomTab]->aPageZoomY = aDefPageZoomY;
}
+ // The loop above delete'd and re-new'd pTabData[] entries (including
the
Review Comment:
The comment refers to the code lines below that where added. Basically all
we do is trigger a refresh of the index and nothing else.
The culprit lines are
```
delete pTabData[nTab];
pTabData[nTab] = new
ScViewDataTable;
```
I think it is that far below because we do not read the index before that
point. The If else clause i think ends in 2942. so we could move the code in
2954.
The code needs to be outside the if - else clause in order to ensure that
the code is refreshed. Better would be not handle the index static, but
recalculate the index every time we want to read it, because on today
architecture thats faster. (says the AI, and it is plausible to me :D ) there
are more details at:
https://github.com/apache/openoffice/blob/bazel-migration/bug-readme.md#14-calc-crash-on-open-av--latent-uaf-debug-crt-deterministic-not-a-migration-bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
