jimjag commented on PR #520: URL: https://github.com/apache/openoffice/pull/520#issuecomment-7012513486
Thanks Pedro, those notes help. New databases: create, save, reopen and populate via SQL all work, including LOBs, backup and recovery after a kill -9. Tested on macOS with JDK 8, 11, 17 and 21, and on Linux with JDK 21. Old 1.8 databases open, both clean ones as well as "dirty" ones (not shut down cleanly). And yes, the dialog works :) Opening a 1.8 database asks whether to convert it. `Yes` converts it. `No` refuses the open and leaves the file untouched. After converting, a plain Save works and writes a 2.5.0 database, so you don't need `Save As`. One thing I still need to look at: during a UI test, a converted file got rewritten as 2.5.0 even though I closed it without saving. Since the conversion is one-way, that will go in the release notes if I don't track it down first. I'll reference i121837 when this gets merged. Fred's offer is great news. 2.5.0 is the newest release that still opens 1.8 files, so it's as far as we can go for now. If upstream brought back the storage hooks and kept 1.8 read support, we could drop most of our patch and move to current releases. Do you want to contact him, or should I? Cheers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
