Hi Eike,
Eike Rathke skrev:
Why initialize first and then immediately assign another value? I'd
write that as
BOOL bAssumeEnglishNumbers =
SC_MOD()->GetAppOptions().GetNumberRecognitionAssumeEnglish()
Agreed.
Note also the use of bool/true versus BOOL/TRUE, strictly spoken they
are different types.
Semantically there's a slight difference between the naming of
NumberRecognitionAssumeEnglish and what the patch respectively the
already existing code actually does: it doesn't necessarily parse
a number as an en-US number; it will still replace the decimal separator
under certain conditions to convert from an en-US number, but will
always parse a number of the current locale. It's more
a NumberRecognitionFuzzyness ;-)
I agree that the wording is not technical correct. However, please don't
forget that the end user will experience 1.000 is always recognised as
the English value of 1 despite 1.000 being 1000 in lots of locales. The
user must also be able to set this var. Thus, the wording reflects how
the user experiences it.
In the main code line I would even split the code for HTML and RTF at
that place and implement something different for RTF that takes the RTF
language tag into account, which would be the proper solution.
I already gathered that from the fact that you leave both
http://www.openoffice.org/issues/show_bug.cgi?id=50670 and
http://www.openoffice.org/issues/show_bug.cgi?id=38494 open.
I agree it would be even more powerful to evaluate on RTF's language
tag. However, immediate action is necessary.
Søren
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
